Skip to content

Prompt for CodeLLDB settings only when launching a debug session #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthewbastien
Copy link
Member

Show an information modal when launching via CodeLLDB and the appropriate settings haven't been applied instead of showing a warning message on startup.

@matthewbastien
Copy link
Member Author

I'm going to merge this. The failed tests are unrelated to this change and have been failing in nightly since at least yesterday.

@matthewbastien matthewbastien merged commit 7fa7cb1 into swiftlang:main Feb 12, 2025
15 of 16 checks passed
@matthewbastien matthewbastien deleted the lazily-prompt-code-lldb branch February 12, 2025 18:27
@matthewbastien matthewbastien added the needs verification Issue has been fixed, but requires verification before closing label Feb 12, 2025
plemarquand added a commit that referenced this pull request Feb 13, 2025
@plemarquand
Copy link
Contributor

Verified in cef4e6c

@plemarquand plemarquand removed the needs verification Issue has been fixed, but requires verification before closing label Mar 26, 2025
@rbenegal rbenegal moved this from Needs Verification to Done in Swift Extension for Visual Studio Code Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants