Cleanup extension activation #1491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
Refactor the extension activation method such that it only starts up the necessary services and registers their disposables for extension deactivation. The startup order of services has been tweaked slightly so that it will fail fast if the toolchain is not configured properly. Fixes a few services that were registred for disposal twice. Fixes up `registerDebugger` so that toggling the setting works immediately instead of silently requiring an extension restart before taking effect.
plemarquand
force-pushed
the
cleanup-extension-activation
branch
from
34b4500 to
509d246
Compare
rbenegal
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the extension activation method such that it only starts up the necessary services and registers their disposables for extension deactivation. The startup order of services has been tweaked slightly so that it will fail fast if the toolchain is not configured properly. Fixes a few services that were registred for disposal twice.
Fixes up
registerDebuggerso that toggling the setting works immediately instead of silently requiring an extension restart before taking effect.