Skip to content

Have single instance of task provider #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/WorkspaceContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import { DocCDocumentationRequest, ReIndexProjectRequest } from "./sourcekit-lsp
import { TestKind } from "./TestExplorer/TestKind";
import { isValidWorkspaceFolder, searchForPackages } from "./utilities/workspace";
import { SwiftPluginTaskProvider } from "./tasks/SwiftPluginTaskProvider";
import { SwiftTaskProvider } from "./tasks/SwiftTaskProvider";

/**
* Context for whole workspace. Holds array of contexts for each workspace folder
Expand All @@ -49,6 +50,7 @@ export class WorkspaceContext implements vscode.Disposable {
public languageClientManager: LanguageClientToolchainCoordinator;
public tasks: TaskManager;
public diagnostics: DiagnosticsManager;
public taskProvider: SwiftTaskProvider;
public pluginProvider: SwiftPluginTaskProvider;
public subscriptions: vscode.Disposable[];
public commentCompletionProvider: CommentCompletionProviders;
Expand Down Expand Up @@ -78,6 +80,7 @@ export class WorkspaceContext implements vscode.Disposable {
this.languageClientManager = new LanguageClientToolchainCoordinator(this);
this.tasks = new TaskManager(this);
this.diagnostics = new DiagnosticsManager(this);
this.taskProvider = new SwiftTaskProvider(this);
this.pluginProvider = new SwiftPluginTaskProvider(this);
this.documentation = new DocumentationManager(extensionContext, this);
this.currentDocument = null;
Expand Down
5 changes: 3 additions & 2 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import * as vscode from "vscode";
import * as commands from "./commands";
import * as debug from "./debugger/launch";
import { ProjectPanelProvider } from "./ui/ProjectPanelProvider";
import { SwiftTaskProvider } from "./tasks/SwiftTaskProvider";
import { FolderEvent, FolderOperation, WorkspaceContext } from "./WorkspaceContext";
import { FolderContext } from "./FolderContext";
import { TestExplorer } from "./TestExplorer/TestExplorer";
Expand Down Expand Up @@ -96,7 +95,9 @@ export async function activate(context: vscode.ExtensionContext): Promise<Api> {
context.subscriptions.push(new SelectedXcodeWatcher(outputChannel));

// Register task provider.
context.subscriptions.push(SwiftTaskProvider.register(workspaceContext));
context.subscriptions.push(
vscode.tasks.registerTaskProvider("swift", workspaceContext.taskProvider)
);

// Register swift plugin task provider.
context.subscriptions.push(
Expand Down
3 changes: 1 addition & 2 deletions test/integration-tests/tasks/SwiftTaskProvider.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import * as vscode from "vscode";
import * as assert from "assert";
import { WorkspaceContext } from "../../../src/WorkspaceContext";
import {
SwiftTaskProvider,
createSwiftTask,
createBuildAllTask,
getBuildAllTask,
Expand Down Expand Up @@ -154,7 +153,7 @@ suite("SwiftTaskProvider Test Suite", () => {
});

test("includes product release task", async () => {
const taskProvider = new SwiftTaskProvider(workspaceContext);
const taskProvider = workspaceContext.taskProvider;
const tasks = await taskProvider.provideTasks(
new vscode.CancellationTokenSource().token
);
Expand Down
Loading