Handle having multiple Swift toolchains on Windows #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for `which swift` to return multiple lines if the user has more than one Swift toolchain installed. Windows behavior is to use the first one, so we use it as well but also warn the user.
plemarquand
requested review from
adam-fowler,
daveyc123,
matthewbastien and
award999
|
@compnerd, @tristanlabelle what are your thoughts on this? |
|
The runtime is not ABI stable, so anything other than the single version installation seems fragile - there's no guarantee that the right runtime is being used. There's a desire to support multiple versions, which is why the installer has gained support for that, but the work to support parallel installs is incomplete. This seems to be something which would be nice to support, indicating ambiguity seems like a positive, but we still have more work to do. |
award999
approved these changes
May 16, 2024
adam-fowler
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for
which swiftto return multiple lines if the user has more than one Swift toolchain installed. Windows behavior is to use the first one, so we use it as well but also warn the user.