Handle swift-testing events > 8kb #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
daveyc123,
adam-fowler,
matthewbastien and
award999
Using Node's built in net.Socket imposes an 8kb message limit on the JSONL writes from swift-testing. This meant that if a test case had a lot of iterations the `test` event would overrun the limit and the message would never be read. Create our own readable stream and manage pausing/resuming the pipe on data/drain events. This allows for swift-testing to write whatever size messages it wants.
plemarquand
force-pushed
the
named-pipe-backpressure
branch
from
04b6aed to
03fc340
Compare
award999
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Node's built in net.Socket imposes an 8kb message limit on the JSONL writes from swift-testing. This meant that if a test case had a lot of iterations the
testevent would overrun the limit and the message would never be read.Create our own readable stream and manage pausing/resuming the pipe on data/drain events. This allows for swift-testing to write whatever size messages it wants.