Skip to content

Improve LSP configuration change notification #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthewbastien
Copy link
Member

@matthewbastien matthewbastien commented Jun 11, 2024

Issue: #747

Adds extra checks surrounding enablement of SourceKit-LSP to improve the wording of the configuration changed notification.

Copy link
Contributor

@award999 award999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@award999
Copy link
Contributor

@swift-server-bot test this please

Copy link
Contributor

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@matthewbastien
Copy link
Member Author

@swift-server-bot test this please

@matthewbastien matthewbastien merged commit bee8ce3 into swiftlang:main Jun 13, 2024
2 checks passed
@matthewbastien matthewbastien deleted the improve-lsp-config-notification branch June 13, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants