Always register the swift-lldb debug adapter provider #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
reviewed
Jun 12, 2024
Issue: swiftlang#848 We can always register this and that way the user does not need to reload the window when use change to using lldb-dap. Now they can use the updated debug configurations right away If the lldb-dap path doesn't exist or it is not in the toolchain, the debug session bales without doing anything, so we'll check if lldb-dap exists and show error message if it doesn't
award999
force-pushed
the
lldb-dap-provider
branch
from
56f4f6b to
b23f57e
Compare
|
@adam-fowler the debug session does nothing if the path does not exist or cannot find in toolchain, so added a check to verify that the the debug adapter does exist so the user gets an error message instead of silently failing. I see that we are already listening to changes to |
adam-fowler
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #848
We can always register this and that way the user does not need to reload the window when use change to using lldb-dap. Now they can use the updated debug configurations right away