Skip to content

Add UI Settings Group #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

plemarquand
Copy link
Contributor

Move the following settings in to their own group. Their ID does not change so there is no need to deprecate them or make code changes.

  • swift.excludePathsFromPackageDependencies
  • swift.showBuildStatus
  • swift.showCreateSwiftProjectInWelcomePage
  • swift.openAfterCreateNewProject

Issue #901

Move the following settings in to their own group. Their ID does not
change so there is no need to deprecate them or make code changes.

- `swift.excludePathsFromPackageDependencies`
- `swift.showBuildStatus`
- `swift.showCreateSwiftProjectInWelcomePage`
- `swift.openAfterCreateNewProject`

Issue swiftlang#901
@award999
Copy link
Contributor

Debugger and SourceKit-LSP settings put something in the setting ID. So we could add .userInterface to these settings (ex. swift.userInterface.showBuildStatus) to follow that theme and would show that category in the Settings editor (ex. Swift › User Interface: Show Build Status). Now 3 of these settings are fairly new so not quite as concerned about changing them as not too many people should have set, but swift.excludePathsFromPackageDependencies has been around a little longer so not sure how concerned we should be

@plemarquand
Copy link
Contributor Author

Yeah I was hesitant to change the actual setting IDs as these settings have been released and so we'd need to maintain/migrate them. Does adding a segment to the ID have any benefit other than code clarity?

@award999
Copy link
Contributor

Shows up marginally nicer in the Setting editor, ex. Swift › User Interface: Show Build Status

@adam-fowler
Copy link
Contributor

This would mean we would have to deprecate the old settings and point people to the new ones. Unless we are making a significant gain I wouldn't bother changing them.

@plemarquand plemarquand merged commit e27ba74 into swiftlang:main Jun 20, 2024
8 checks passed
@plemarquand plemarquand deleted the add-ui-settings-group branch June 20, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants