Skip to content

Add tests for LSP test discovery #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

plemarquand
Copy link
Contributor

Adds comprehensive tests for LSP test discovery. Removes the capabilities cache since all it was doing was short circuiting a nested property lookup.

Adds comprehensive tests for LSP test discovery. Removes the
capabilities cache since all it was doing was short circuiting a nested
property lookup.
Copy link
Contributor

@award999 award999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits but looks good

@plemarquand plemarquand merged commit 6662913 into swiftlang:main Jun 20, 2024
8 checks passed
@plemarquand plemarquand deleted the lsp-test-discovery-tests branch June 20, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants