Ensure build output is printed on swift-testing compiler error #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing a swift-testing test run with code that fails to compile the build output was being discarded. This made it hard to see why tests weren't being run. This was happening because swift-testing tests don't have their run started until the .swift-testing binary has sent all of its `test` events, which enumerate the parameterized test cases. This means that build output is witheld until the run starts. If there is a compile error, unless we call `testRunStarted()` to flush the buffer of test result output, nothing is printed to the Test Results panel and build output is lost.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
adam-fowler
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a swift-testing test run with code that fails to compile the build output was being discarded. This made it hard to see why tests weren't being run.
This was happening because swift-testing tests don't have their run started until the .swift-testing binary has sent all of its
testevents, which enumerate the parameterized test cases. This means that build output is witheld until the run starts.If there is a compile error, unless we call
testRunStarted()to flush the buffer of test result output, nothing is printed to the Test Results panel and build output is lost.