Update title of command to select toolchain (or Xcode directory) #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
award999
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Thanks for the PR 👍 but this is not just a macOS concept anymore. @matthewbastien can you advise on this one?
matthewbastien
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Thanks for the contribution! As @award999 pointed out the Swift: Select Toolchain... command is available on all platforms (although it doesn't do much on Windows at the moment).
I think it's best to move the text to the bulleted list directly above it and change the wording to something like:
- **Select Toolchain**: Select which locally installed Swift toolchain you want to use Swift tools from.
|
Requested change integrated. Ready for re-review/merge 😄 |
adam-fowler
approved these changes
Jun 29, 2024
award999
approved these changes
Jul 2, 2024
0xTim
approved these changes
Jul 2, 2024
matthewbastien
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing an outdated part of the README that probably should have landed with #817.
I am not sure if the Select Toolchain command is only available under macOS. That might be an outdated concept since the previous command was about selecting Xcode versions, which obviously are only on macOS. Toolchains are available on other platforms. I'm happy to update this PR if someone wants to confirm this one way or another.