Skip to content

Allow VS Code to recognise files with "sourcekit-lsp" scheme to provide Semantic Functionality through SourceKitLSP #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lokesh-tr
Copy link
Contributor

This PR makes VS Code to recognise files with scheme "sourcekit-lsp", thereby allowing them to be handled by SourceKitLSP and provide Semantic Functionality. Specifically, This PR enables Semantic Functionality in Macro Expansion Reference Document's Peeked Editors.

Refer to the sourcekit-lsp PR below for more information on what semantic functionality is supported as of now.

Accompanying PR in sourcekit-lsp repository: swiftlang/sourcekit-lsp#1610


Expansion of Swift Macros in Visual Studio Code - Google Summer Of Code 2024
@lokesh-tr @ahoppen @adam-fowler

Copy link
Contributor

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing about converting between vscode and lsp types

@lokesh-tr lokesh-tr force-pushed the semantic-functionality-in-macro-expansion-reference-document branch from 14bb403 to 866d41d Compare August 15, 2024 13:33
… it to SourceKitLSP inorder to provide Semantic Functionality
@lokesh-tr lokesh-tr force-pushed the semantic-functionality-in-macro-expansion-reference-document branch from 866d41d to 32ba557 Compare August 15, 2024 13:47
Copy link
Contributor

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lokesh-tr lokesh-tr marked this pull request as ready for review August 16, 2024 07:33
@lokesh-tr lokesh-tr changed the title Allow VS Code to recognise files with "sourcekit-lsp" scheme to provide Semantic Functionality through SourceKitLSP 🚦 Allow VS Code to recognise files with "sourcekit-lsp" scheme to provide Semantic Functionality through SourceKitLSP Aug 16, 2024
@adam-fowler adam-fowler merged commit d131215 into swiftlang:main Aug 16, 2024
lokesh-tr added a commit to lokesh-tr/vscode-swift that referenced this pull request Aug 19, 2024
… it to SourceKitLSP inorder to provide Semantic Functionality (swiftlang#990)
lokesh-tr added a commit to lokesh-tr/vscode-swift that referenced this pull request Aug 19, 2024
… it to SourceKitLSP inorder to provide Semantic Functionality (swiftlang#990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants