Merge pull request swiftlang#28896 from rintaro/ide-completion-rdar58098222

[CodeCompletion] Always look into decls to find the parsed expression

Author: rintaro

lib/IDE/ExprContextAnalysis.cpp

@@ -161,8 +161,6 @@ class ExprFinder : public ASTWalker {
     return {isInterstingRange(S), S};
   }
 
-  bool walkToDeclPre(Decl *D) override { return isInterstingRange(D); }
-
   bool walkToTypeLocPre(TypeLoc &TL) override { return false; }
   bool walkToTypeReprPre(TypeRepr *T) override { return false; }
 };

test/SourceKit/CodeComplete/complete_sequence_bodyrange.swift

@@ -0,0 +1,57 @@
+class TestChain {
+  class Child {
+    var value: Struct1?
+  }
+  class Struct1 {
+    var value: Struct2
+  }
+  class Struct2 {
+    var prop1: Int
+    var prop2: Int
+  }
+
+  var child: Child!
+
+  func foo() {
+    let _ = child.value?.value.
+  }
+}
+
+// rdar://problem/58098222
+
+// RUN: %sourcekitd-test \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s == \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s == \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s == \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s == \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s == \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s == \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s == \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s == \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s == \
+// RUN:   -req=complete -req-opts=reuseastcontext=1 -pos=16:32 %s -async -- %s | %FileCheck %s
+
+// CHECK-NOT: key.name: "prop1"
+// CHECK-NOT: key.name: "prop2"
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK: key.name: "prop1",
+// CHECK: key.name: "prop2",
+// CHECK-NOT: key.name: "prop1"
+// CHECK-NOT: key.name: "prop2"