[CodeCompletion] Always look into decls to find the parsed expression #28896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fast completion scenario, 'AbstractFunctionDecl' may have the body from the different file than the decl itself. Thay may confuses source range checking. As a workaround, always look into decls regardless of the range. This should not regress the speed of the searching much because statements/expressions (including nested function bodies) in the decl is still skipped if it's outside the range. rdar://problem/58098222
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@benlangmuir Another solution is to only check the end loc (i.e. |
benlangmuir
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fast completion scenario,
AbstractFunctionDeclmay have the body from the different file than the decl itself. That may confuses source range checking.As a workaround, always look into decls regardless of the range. This should not regress the speed of the searching much because statements/expressions (including the nested function bodies) in the decl is still skipped if they are outside the range.
rdar://problem/58098222