Run packaging scripts and smoke test on CI #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my local environment, |
kateinoigakukun
previously approved these changes
Nov 14, 2019
|
Same for me, not sure if we've stumbled upon the same issue though. I was able to finally link without errors on a Linux box (still getting ar/ranlib errors despite |
MaxDesiatov
force-pushed
the
swiftwasm
branch
from
f2bdbfe to
42c6603
Compare
MaxDesiatov
force-pushed
the
test-package
branch
from
8b49db2 to
1e2ef41
Compare
|
Build fails because of this macro. We need to add Wasm condition here. https://github.com/apple/swift/blob/9884e5019353d1d6a3438b2678baf6a49b61e3af/stdlib/private/StdlibUnittest/SymbolLookup.swift#L15 |
|
Not sure now if that file should be compiled at all, would any |
|
This file didn't exist before Oct 24, 2019, that seems to be the explanation 🙂 |
MaxDesiatov
added
the
continuous integration
kateinoigakukun
pushed a commit
that referenced
this pull request
Dec 15, 2019
kateinoigakukun
pushed a commit
that referenced
this pull request
Dec 15, 2019
Any changes in this repository should be tested with the packaging script and a basic smoke test that compiles `hello.swift` on CI. In the future packaging and linking scripts should be moved to this repository, `swiftwasm-sdk` and `swiftwasm-package-sdk` projects probably would be archived when that happens. For now we're pulling the scripts from `swiftwasm-package-sdk` as it is. * Run packaging scripts and smoke test on CI * Make prepare-package.sh executable * Make SymbolLookup.swift compilable for wasm * Use GitHub Actions upload/download steps * Remove packaging steps from ci-*.sh * Move prepare-package.sh to main.yml to avoid clone * Refine formatting in .github/workflows/main.yml
kateinoigakukun
pushed a commit
that referenced
this pull request
Jan 11, 2020
Any changes in this repository should be tested with the packaging script and a basic smoke test that compiles `hello.swift` on CI. In the future packaging and linking scripts should be moved to this repository, `swiftwasm-sdk` and `swiftwasm-package-sdk` projects probably would be archived when that happens. For now we're pulling the scripts from `swiftwasm-package-sdk` as it is. * Run packaging scripts and smoke test on CI * Make prepare-package.sh executable * Make SymbolLookup.swift compilable for wasm * Use GitHub Actions upload/download steps * Remove packaging steps from ci-*.sh * Move prepare-package.sh to main.yml to avoid clone * Refine formatting in .github/workflows/main.yml
MaxDesiatov
added a commit
that referenced
this pull request
Jan 29, 2020
Any changes in this repository should be tested with the packaging script and a basic smoke test that compiles `hello.swift` on CI. In the future packaging and linking scripts should be moved to this repository, `swiftwasm-sdk` and `swiftwasm-package-sdk` projects probably would be archived when that happens. For now we're pulling the scripts from `swiftwasm-package-sdk` as it is. * Run packaging scripts and smoke test on CI * Make prepare-package.sh executable * Make SymbolLookup.swift compilable for wasm * Use GitHub Actions upload/download steps * Remove packaging steps from ci-*.sh * Move prepare-package.sh to main.yml to avoid clone * Refine formatting in .github/workflows/main.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any changes in this repository should be tested with the packaging script and a basic smoke test that compiles
hello.swifton CI.In the future packaging and linking scripts should be moved to this repository,
swiftwasm-sdkandswiftwasm-package-sdkprojects probably would be archived when that happens. For now we're pulling the scripts fromswiftwasm-package-sdkas it is.