Skip to content

Remove sed backup file from toolchain #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 25, 2020
Merged

Remove sed backup file from toolchain #2081

merged 8 commits into from
Oct 25, 2020

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Oct 23, 2020 •
edited
Loading

macOS's sed command always requires -i option value and -e was recognized as backup suffix, so usr/lib/swift/wasi/wasm32/wasi.modulemap-e was created in toolchain.

MaxDesiatov
MaxDesiatov previously approved these changes Oct 23, 2020
View reviewed changes
Copy link

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch 👏

@kateinoigakukun kateinoigakukun changed the title [WASM] Remove sed backup file from toolchain Remove sed backup file from toolchain Oct 23, 2020
@kateinoigakukun kateinoigakukun mentioned this pull request Oct 23, 2020
Merged
@kateinoigakukun kateinoigakukun force-pushed the katei/remove-sed-backup-file branch from 1cf3afc to 25defa0 Compare October 23, 2020 15:31
@kateinoigakukun kateinoigakukun mentioned this pull request Oct 23, 2020
Merged
@kateinoigakukun
[WASM] Remove sed backup file from toolchain
e2a9879
@kateinoigakukun
[WASM] Replace absolute path in swift_static's wasi.modulemap
80ec0a7
@kateinoigakukun
[WASM] Use backup option and remove them
9a925f5
@kateinoigakukun
[WASM] Remove swift_static workarounds
ef49678 
Driver users should provide -static-executable or -static-stdlib to load
module from swift_static. These options tell the frontend
-use-static-resource-dir which enables to include swift_static dir
@kateinoigakukun
[WASM] Use backup option and remove them
7810ae4
@kateinoigakukun
[WASM] Add integration tests
8013ade
@kateinoigakukun kateinoigakukun force-pushed the katei/remove-sed-backup-file branch from 76f6789 to 8013ade Compare October 24, 2020 05:45
@kateinoigakukun kateinoigakukun force-pushed the katei/remove-sed-backup-file branch from d352b7e to ef4fe4a Compare October 25, 2020 04:08
MaxDesiatov
MaxDesiatov approved these changes Oct 25, 2020
View reviewed changes
Copy link

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit 8c34b0b into swiftwasm Oct 25, 2020
@kateinoigakukun kateinoigakukun deleted the katei/remove-sed-backup-file branch October 25, 2020 08:50
MaxDesiatov added a commit that referenced this pull request Oct 25, 2020
@MaxDesiatov
Merge pull request #2083 from swiftwasm/katei/remove-sed-backup-file-5.3
2db367f 
Remove sed backup file from toolchain for 5.3 branch, cherry-pick #2081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov