Propagate -use-static-resource-dir for merge-module #2097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
added a commit
to swiftwasm/carton
that referenced
this pull request
Oct 26, 2020
MaxDesiatov
approved these changes
Oct 26, 2020
kateinoigakukun
added a commit
to swiftwasm/carton
that referenced
this pull request
Oct 27, 2020
This reverts commit 285d2ae.
kateinoigakukun
added a commit
to swiftwasm/carton
that referenced
this pull request
Oct 28, 2020
* Remove unnecessary linker flags * Remove destination json * Import CoreFoundation explicitly to link it * Remove Destination.swift model file * Restore triple option * Update default toolchain * Workaround until swiftwasm/swift#2097 * Revert "Workaround until swiftwasm/swift#2097" This reverts commit 285d2ae. * Update toolchain version * Warn use of --destination * Apply suggestions from code review Co-authored-by: Max Desiatov <[email protected]> Co-authored-by: Max Desiatov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.