Skip to content

Fix unit tests part1 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 12, 2020
Merged

Fix unit tests part1 #31

merged 5 commits into from
Jan 12, 2020

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jan 11, 2020 •
edited
Loading

This is a sample PR for #29

  • 7a3f27e 629b8f2 Disable mmap and simd related test case because wasm doesn't have enough api to implement it.
  • ed5f4fc Implement CommandLine.arguments to run stdlib test cases using StdlibUnittest framework.
  • 552d314 Run StdlibUnittest test cases in process instead of spawning child processes.

@kateinoigakukun kateinoigakukun force-pushed the katei/fix-unit-tests-part1 branch from ab23405 to fc15b46 Compare January 11, 2020 04:56
@kateinoigakukun kateinoigakukun force-pushed the katei/fix-unit-tests-part1 branch from a86676f to 552d314 Compare January 12, 2020 01:21
@kateinoigakukun
Copy link
Member Author

ready for review

MaxDesiatov
MaxDesiatov approved these changes Jan 12, 2020
View reviewed changes
Copy link

@MaxDesiatov MaxDesiatov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! Ready for merging.

@kateinoigakukun kateinoigakukun merged this pull request into swiftwasm:swiftwasm Jan 12, 2020
@kateinoigakukun kateinoigakukun deleted the katei/fix-unit-tests-part1 branch January 12, 2020 13:33
MaxDesiatov pushed a commit that referenced this pull request Jan 29, 2020
@kateinoigakukun
Fix unit tests part1 (#31)
f4fbad5 
* [WASM] Disable mmap test case for WASI OS due to lack of WASI API

* [WASM] Disable simd test case for WASI OS

simd api maybe stable in future https://github.com/WebAssembly/simd

* [WASM] Fix to build pthread pollyfill only when wasi sdk

* [WASM] Implement parsing command line arguments

* [WASM] Run StdlibUnittest in process instead of child proc
MaxDesiatov pushed a commit that referenced this pull request Jan 29, 2020
@pull
Merge pull request #31 from apple/master
d1bc17c 
[pull] swiftwasm from apple:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov