Avoid to emit inline asm for WebAssembly to build as debuggable #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @kateinoigakukun! |
MaxDesiatov
pushed a commit
that referenced
this pull request
Oct 22, 2019
When I build swift code as debuggable, I got the following error: ``` error: couldn't allocate input reg for constraint 'r' ``` This means we can't use `InlineAsm` with registers because WASM doesn't have registers. Swift uses `InlineAsm` to extend lifetime of variable for debugging. So I changed to avoid to use it. After this change, we can build swift standard library as debuggable via `./utils/build-script --debug`. ## References - https://gcc.gnu.org/onlinedocs/gcc/Simple-Constraints.html#Simple-Constraints
MaxDesiatov
pushed a commit
that referenced
this pull request
Nov 14, 2019
When I build swift code as debuggable, I got the following error: ``` error: couldn't allocate input reg for constraint 'r' ``` This means we can't use `InlineAsm` with registers because WASM doesn't have registers. Swift uses `InlineAsm` to extend lifetime of variable for debugging. So I changed to avoid to use it. After this change, we can build swift standard library as debuggable via `./utils/build-script --debug`. ## References - https://gcc.gnu.org/onlinedocs/gcc/Simple-Constraints.html#Simple-Constraints
kateinoigakukun
added a commit
that referenced
this pull request
Dec 15, 2019
When I build swift code as debuggable, I got the following error: ``` error: couldn't allocate input reg for constraint 'r' ``` This means we can't use `InlineAsm` with registers because WASM doesn't have registers. Swift uses `InlineAsm` to extend lifetime of variable for debugging. So I changed to avoid to use it. After this change, we can build swift standard library as debuggable via `./utils/build-script --debug`. ## References - https://gcc.gnu.org/onlinedocs/gcc/Simple-Constraints.html#Simple-Constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I build swift code as debuggable, I got the following error:
This means we can't use
InlineAsmwith registers because WASM doesn't have registers.Swift uses
InlineAsmto extend lifetime of variable for debugging. So I changed to avoid to use it.After this change, we can build swift standard library as debuggable via
./utils/build-script --debug.References