Skip to content

[wasm] Revert unnecessary dso_local change #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2023
Merged

[wasm] Revert unnecessary dso_local change #5428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions include/swift/IRGen/Linking.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1627,15 +1627,6 @@ class ApplyIRLinkage {
// TODO: BFD and gold do not handle COMDATs properly
if (Triple.isOSBinFormatELF())
return;
// WebAssembly: hack: comdat + custom section = explosion
// the comdat code assumes section name would be unique for each comdat
// this doesn't happen for metadata.
// And avoid to create GOT because wasm32 doesn't support
// dynamic linking yet
if (Triple.isOSBinFormatWasm()) {
GV->setDSOLocal(true);
return;
}

// COMDATs cannot be applied to declarations. If we have a definition,
// apply the COMDAT.
Expand Down