Skip to content

Throw a ValidationException when document contains duplicate resources #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

JaZo
Copy link
Member

@JaZo JaZo commented Oct 4, 2019

Description

The DocumentParser now throws a ValidationException when a document contains duplicate resources. Earlier we had a workaround for duplicate resources, but that is not allowed according to the spec, so I also removed the workaround.

Motivation and context

See https://jsonapi.org/format/#document-resource-object-identification

How has this been tested?

Tested with new unit test.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@JaZo JaZo force-pushed the feature/validate-unique-resources branch from 048f189 to 975762f Compare October 4, 2019 13:34
@JaZo JaZo merged commit de431b5 into master Oct 4, 2019
@JaZo JaZo deleted the feature/validate-unique-resources branch October 4, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant