Declare strict types #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've declared strict types in all classes and also configured PHP-CS-Fixer to make it required.
Motivation and context
To improve code quality and reduce errors.
N.B. Sometimes an id is provided as integer and we don't want to break on that small detail, so I cast them to a string before setting them on the item. Since the type declaration of the id was already a string the output won't change.
How has this been tested?
Tested in a real life application.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:N.B. Declaring strict types can be considered a breaking change, but since we already have strict type checks in our parsers and I added the cast for the ID's, I believe the vast majority of users will not be affected.
Checklist:
Go over all the following points, and put an
x
in all the boxes that apply.