follow the property access model with children #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return array - array of RouteObjectInterface's | ||
| * @return RouteObjectInterface[] | ||
| * | ||
| */ | ||
| public function getRouteChildren() |
There was a problem hiding this comment.
but we want to keep getRouteChildren() ?
There was a problem hiding this comment.
i would keep it, it filters to only return route objects and not other children
lsmith77
added a commit
that referenced
this pull request
Oct 9, 2013
follow the property access model with children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this change, routes will appear again in the sonata phpcr-odm as this follows the property access model of having getChildren to get the children property.