Symfony 2.8 support #325
Closed
Symfony 2.8 support #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
should we then just try to remove deprecation notices/warnings then ? which will be hard because some dev dependencies relies on deprecated features methods/classes. So upgrading is mandatory. |
| "phpunit/php-code-coverage": "@stable", | ||
| "sonata-project/doctrine-phpcr-admin-bundle": "~1.1", | ||
| "sonata-project/doctrine-phpcr-admin-bundle": "^1.1|^2.0", |
There was a problem hiding this comment.
we should not allow sonata admin 2.0 as per #325 (comment)
|
i actually don't mind the deprecations for this branch. i am fine just setting the deprecation helper to not treat them as errors. we need to fix them for the version that supports 3.0 but for 2.8 i would rather have something simple that works with 2.3-2.8 and then we move on with the 3.0 upgrade and don't need workarounds for older symfony versions. |
Merged
|
continuing in #326 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.