Skip to content

PHP 8.0 Compatibility #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2020
Merged

PHP 8.0 Compatibility #457

merged 2 commits into from
Dec 3, 2020

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Dec 2, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #456
License MIT
Doc PR

@blankse blankse marked this pull request as ready for review December 2, 2020 14:23
@blankse blankse marked this pull request as draft December 2, 2020 14:24
ausi
ausi reviewed Dec 2, 2020
View reviewed changes
@blankse @ausi
Update .travis.yml
7fae8f0 
Co-authored-by: Martin Auswöger <[email protected]>
@blankse blankse marked this pull request as ready for review December 3, 2020 06:48
@blankse
Copy link
Contributor Author

blankse commented Dec 3, 2020

It works with "ignore-platform-req=php".
Since jackalope/jackalope-doctrine-dbal is just a dev dependency, i think it would be okay for now.

@dbu dbu merged commit 48c603c into symfony-cmf:master Dec 3, 2020
@blankse blankse deleted the patch-1 branch December 3, 2020 07:42
@ausi ausi mentioned this pull request Dec 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi ausi left review comments

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blankse @dbu @ausi