Bundle standards #52
Bundle standards #52
Conversation
- General Bundle Standards (all) - Meta - Testing component integration
| @@ -13,6 +13,7 @@ | |||
| use Doctrine\Bundle\PHPCRBundle\Migrator\MigratorInterface; | |||
| use Doctrine\ODM\PHPCR\DocumentManager; | |||
|
|
|||
| // dan: What does this do ?? | |||
| class Page implements MigratorInterface | |||
There was a problem hiding this comment.
there is a bit of doc here http://symfony.com/doc/current/cmf/getting_started/installing_symfony_cmf.html#adding-new-pages
it was added in #35
|
Added WebTests for Sonata. Had to add some dependencies and fix the Configuration class a little. Good to merge as far as I am concerned. |
| @@ -38,6 +38,7 @@ public function getConfigTreeBuilder() | |||
| ->fixXmlConfig('controller_by_alias', 'controllers_by_alias') | |||
| ->fixXmlConfig('controller_by_class', 'controllers_by_class') | |||
| ->fixXmlConfig('template_by_class', 'templates_by_class') | |||
| ->addDefaultsIfNotSet() | |||
There was a problem hiding this comment.
do we want that? its a change in behaviour in case you want to disable something
There was a problem hiding this comment.
Well, the DI extension uses keys from $config['routing']. It crashes if these defaults are not defined - the test uses the most minimal configuration, so this hasn't been noticed before presumably.
Not sure I see why its bad, although I can certainly see a case for tidying up the DI extension, its a bit chaotic.
| ->add('body', 'textarea') | ||
| ; | ||
| } | ||
|
|
||
| protected function configureSideMenu(MenuItemInterface $menu, $action, AdminInterface $childAdmin = null) |
There was a problem hiding this comment.
Removed this. Should we keep it? What is the intention of sidemenu.publish_start_end_date and the other one? /cc @lsmith77
There was a problem hiding this comment.
it was a quick hack to add a preview link and also give some documentation on the logic behind the publish workflow. the later part should now be moved to the admin extension somehow. the former is something we really should figure out. we could create a form widget that just lists all the pages that are linked to the given content directly or indirectly (ie. f.e. for a block it would find what content is linked to the block and from there figure out the routes).
There was a problem hiding this comment.
that would be this issue i think:
sonata-project/SonataDoctrinePhpcrAdminBundle#116
i wonder if we really should build that right into sonata, with an
optional dependeny on CmfRoutingBundle or if we could for example
provide an extension for this. but not sure if extensions can add to the
sidebar...
There was a problem hiding this comment.
So are we alright to leave this out for now if we have that issue?
There was a problem hiding this comment.
i added a link to the changes here in the sonata issue about the preview link.
i don't really understand what the publish workflow thingy was about, if it just was doing documentation. @lsmith77 can you create an issue on the corebundle if we should add something to the publish workflow admin extensions? maybe providing the label and the help text in the form would be enough?
lets merge this PR, the publish workflow things are already displaying broken, so it seems not too important to me.
There was a problem hiding this comment.
ok, btw there is already -some- help text: http://cmf.liip.ch/en/admin/bundle/simplecms/page/cms/simple/service/contact/edit#s51ffb1ad3a7e1_2
This addresses
Adds some web tests for Sonata.