Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Block - move mappings to xml #199

Merged
merged 3 commits into from
Aug 6, 2013
Merged

Conversation

rmsint
Copy link
Contributor

@rmsint rmsint commented Jul 26, 2013

Q A
Doc fix? yes
New docs? no
Applies to BlockBundle, cmf-sandbox
Fixed tickets symfony-cmf/block-bundle#89, symfony-cmf/cmf-sandbox#191

@dbu
Copy link
Member

dbu commented Jul 26, 2013

looks good to me. have to wait until we merge blocks

@lsmith77
Copy link
Member

lsmith77 commented Aug 5, 2013

ready now?

@rmsint
Copy link
Contributor Author

rmsint commented Aug 6, 2013

We also have an issue open to fix and finish the configuration. Not sure if we want to add a few lines to explain that phpcr needs to be enabled now.

Otherwise it is ready

@dbu
Copy link
Member

dbu commented Aug 6, 2013

do you have time to do that today?

the config doc for all RC-ed bundles is not updated either, so we might also merge and update all config doc in one go.

@wouterj
Copy link
Member

wouterj commented Aug 6, 2013

I suggest to wait with the config. There is a high change that we move all the configuration from the bundles into a new reference section in the new doc structure. This means that we need to rewrite and update things then.

@rmsint
Copy link
Contributor Author

rmsint commented Aug 6, 2013

done, removed the xml and php config atm, we can add them later then when documenting the configuration properly. (also don't know what the xml config will be)

dbu added a commit that referenced this pull request Aug 6, 2013
@dbu dbu merged commit 5c5c3a6 into symfony-cmf:master Aug 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants