This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Parameter standard naming for class parameters #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dantleech
commented
Aug 2, 2013
dantleech
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | RC1+ |
| Fixed tickets | N/A |
|
I recommend to link to http://symfony.com/doc/current/contributing/code/standards.html#service-naming-conventions |
|
+1 for linking. the |
|
yeah indeed, linking to the standards would be less redundant. there is always the dillema that linking to ano rt her document is less convenient for the user. But +1 anyway. |
|
can you adjust this PR and then we merge? |
|
ping |
|
Added link to service naming conventions instead of repeathing them, merging .. |
dantleech
added a commit
that referenced
this pull request
Aug 14, 2013
Parameter standard naming for class parameters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.