This repository was archived by the owner on Sep 16, 2021. It is now read-only.
cleaning up the menu documentation #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dbu
commented
Aug 4, 2013
dbu
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | MenuBundle |
| Fixed tickets | symfony-cmf/menu-bundle#31 |
| is in the database, you can pass the core router service as | ||
| content_url_generator, make sure the content_key never matches and make your | ||
| menu documents provide the route name and eventual routeParameters. | ||
|
|
There was a problem hiding this comment.
this is integrated into the restructured text above.
|
should #183 be closed in favor of this one? |
|
i think #183 is solved by this, yes. unless @dantleech wanted to add something more, in which case i propose to have an issue with more specific notes, or directly a PR doing the changes. i updated this PR adjusting to all your feedback, i think this should now be ready to merge. |
|
|
||
| .. index:: MenuBundle | ||
|
|
||
| Dependencies | ||
| ------------ | ||
|
|
||
| This bundle is extending the `KnpMenuBundle`_. | ||
| This bundle is extending the `KnpMenuBundle`_. Unless you change defaults and | ||
| provide your own implementations, this bundle also depends on |
|
except from my 2 comments, it can be merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.