Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Fixed travis config #229

Merged
merged 1 commit into from
Aug 9, 2013
Merged

Fixed travis config #229

merged 1 commit into from
Aug 9, 2013

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Aug 9, 2013

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -
Related symfony-cmf/Testing#14

dbu added a commit that referenced this pull request Aug 9, 2013
@dbu dbu merged commit 11e50b6 into symfony-cmf:master Aug 9, 2013
@dbu
Copy link
Member

dbu commented Aug 9, 2013

for a moment i was thinking you wanted travis to test the documentation :-D

@wouterj
Copy link
Member Author

wouterj commented Aug 9, 2013

well, I'm creating a library to do that. It's a very interesting idea I have for some time now. It uses travis to check the documentation standards and lint the ReSt and PHP examples.

Moreover, we can do something like is just in the angular and python docs: Adding test cases to test our examples.

But more on that later...

@dbu
Copy link
Member

dbu commented Aug 9, 2013

oh ok :-)
well if we saw compilation errors, that would certainly help. i don't
always check the rendered output and realized that we accumulate
compilation errors over time.

@wouterj
Copy link
Member Author

wouterj commented Aug 9, 2013

please note that you can always check http://symfony.com/doc/build_errors The CMF errors are merged into the core errors for the english translation and you can find them because they are prefixed with /cmf/

@dbu
Copy link
Member

dbu commented Aug 9, 2013

i know that i could. but notes on PR and the README would make me
notice there is something wrong. so looking forward to when your doc
testing thing is ready to use :-)

@dantleech
Copy link
Member

@wouterj - I am currently imagining making the bundle test applications self documenting and able to expose they're own code. For example exposing the configuration, twig templates etc used to render the page with short descriptions, like for example http://wwwendt.de/tech/fancytree/demo/ or the jquery documentation.

The MenuBundle test application currently looks like this: http://cmf-menu.dantleech.com/app_test.php

Just an idea really, but practical as everything needs to be tested and its a good oppurtunity to demo how the pages are rendered, how the test bundle is configured etc.

If this is a good idea, maybe there is a way to mix documenation testing and test applications? Or maybe the two should never meet ...

@wouterj
Copy link
Member Author

wouterj commented Aug 9, 2013

@dantleech that sounds very interesting. We should create a seperate issue for this and not hacking this issue further. I continued in #231

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants