Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

[WIP/TODO] Update SimpleCms doc for 1.0 #233

Merged
merged 1 commit into from
Aug 14, 2013

Conversation

dantleech
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to RC1
Fixed tickets

This PR will update the SimpleCms docs for 1.0

lsmith77 added a commit that referenced this pull request Aug 14, 2013
[WIP/TODO] Update SimpleCms doc for 1.0
@lsmith77 lsmith77 merged commit acbbe9f into symfony-cmf:master Aug 14, 2013
@dantleech
Copy link
Member Author

This wasn't for merging, it even had TODO in addition to WIP in the title :)

@lsmith77
Copy link
Member

oops .. sorry for being trigger happy :(

@dantleech
Copy link
Member Author

Can we revert the merge? I replaced the entire multilang section with TODO.

@lsmith77
Copy link
Member

i added some docs here c675aa3

@wouterj
Copy link
Member

wouterj commented Aug 17, 2013

Please do not merge things before making sure it's ready to merge. Just merging a PR with TODO in the title, content and commits doesn't look good to me. Moreover, I now have a messy thing to review and fix...

I prefer reverting,

# ...
persistence:
phpcr:
document_class: Acme\DemoBundle\Document\MySuperPage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces can be removed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants