Skip to content

Add mising parameter #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

martinqt
Copy link
Contributor

This has been merged in the symfony docs repo: symfony/symfony-docs#1816

@gregquat
Copy link
Member

@martinqt
Copy link
Contributor Author

Seems that they only merged it for 2.0 so far. I asked them.

@skeud
Copy link
Contributor

skeud commented Oct 23, 2012

We didn't create 2.0 branch for FR translation as it would have been too much work at the point we managed to be in sync with the master of the EN version.

Hence if it is only in 2.0, you can:

  • close this PR
  • go for creating the 2.0 branch (but as @fabpot mentioned at some point, I think it is not worth the effort and better to focus on the future branches sync) and push your PR to this 2.0 branch

Choice is up to you but I would really advice the 1st proposal ;-)

Best and thanks a lot for the help so far - really appreciated!!!

@martinqt
Copy link
Contributor Author

So if i'm correct this will be done during the future big sync if they merged it.
Well, option 1 also sounds really good to me :)

@martinqt martinqt closed this Oct 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants