Skip to content

Commit 2da7490

Browse files
committed
minor #467 Drop support for PHP 5.3 callbacks (javiereguiluz)
This PR was merged into the master branch. Discussion ---------- Drop support for PHP 5.3 callbacks We now require PHP 5.5.9 in this app, so there's no need to maintain this code. Commits ------- 572b2bf Drop support for PHP 5.3 callbacks
2 parents ddbdf51 + 572b2bf commit 2da7490

File tree

1 file changed

+3
-21
lines changed

1 file changed

+3
-21
lines changed

src/AppBundle/Command/AddUserCommand.php

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -222,13 +222,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
222222
}
223223
}
224224

225-
/**
226-
* This internal method should be private, but it's declared as public to
227-
* maintain PHP 5.3 compatibility when using it in a callback.
228-
*
229-
* @internal
230-
*/
231-
public function passwordValidator($plainPassword)
225+
private function passwordValidator($plainPassword)
232226
{
233227
if (empty($plainPassword)) {
234228
throw new \Exception('The password can not be empty.');
@@ -241,13 +235,7 @@ public function passwordValidator($plainPassword)
241235
return $plainPassword;
242236
}
243237

244-
/**
245-
* This internal method should be private, but it's declared as public to
246-
* maintain PHP 5.3 compatibility when using it in a callback.
247-
*
248-
* @internal
249-
*/
250-
public function emailValidator($email)
238+
private function emailValidator($email)
251239
{
252240
if (empty($email)) {
253241
throw new \Exception('The email can not be empty.');
@@ -260,13 +248,7 @@ public function emailValidator($email)
260248
return $email;
261249
}
262250

263-
/**
264-
* This internal method should be private, but it's declared as public to
265-
* maintain PHP 5.3 compatibility when using it in a callback.
266-
*
267-
* @internal
268-
*/
269-
public function fullNameValidator($fullName)
251+
private function fullNameValidator($fullName)
270252
{
271253
if (empty($fullName)) {
272254
throw new \Exception('The full name can not be empty.');

0 commit comments

Comments
 (0)