Drop support for PHP 5.3 callbacks #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Feb 14, 2017
This PR was merged into the master branch. Discussion ---------- Drop support for PHP 5.3 callbacks We now require PHP 5.5.9 in this app, so there's no need to maintain this code. Commits ------- 572b2bf Drop support for PHP 5.3 callbacks
|
this is broken. Private functions can be used as callable when passing them to built-in functions like The comment about people public for PHP 5.3 only was outdated (it may have true for a previous implementation not using the Question system) |
This was referenced Feb 14, 2017
javiereguiluz
added a commit
that referenced
this pull request
Feb 17, 2017
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
…luz) This PR was squashed before being merged into the master branch (closes #471). Discussion ---------- Reverted #467 to make PHP callbacks work again As explained by @stof in symfony/demo#467 (comment) this change was wrong. Commits ------- 5f31a37 Reverted #467 to make PHP callbacks work again
spider-yamet
added a commit
to spider-yamet/sym_proj
that referenced
this pull request
Apr 16, 2023
…luz) This PR was squashed before being merged into the master branch (closes #471). Discussion ---------- Reverted #467 to make PHP callbacks work again As explained by @stof in symfony/demo#467 (comment) this change was wrong. Commits ------- 5f31a37 Reverted #467 to make PHP callbacks work again
frederickboyd
added a commit
to frederickboyd/frederickboyd
that referenced
this pull request
May 25, 2025
…luz) This PR was squashed before being merged into the master branch (closes #471). Discussion ---------- Reverted #467 to make PHP callbacks work again As explained by @stof in symfony/demo#467 (comment) this change was wrong. Commits ------- 5f31a37 Reverted #467 to make PHP callbacks work again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now require PHP 5.5.9 in this app, so there's no need to maintain this code.