Skip to content

Drop support for PHP 5.3 callbacks #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 3 additions & 21 deletions src/AppBundle/Command/AddUserCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
}
}

/**
* This internal method should be private, but it's declared as public to
* maintain PHP 5.3 compatibility when using it in a callback.
*
* @internal
*/
public function passwordValidator($plainPassword)
private function passwordValidator($plainPassword)
{
if (empty($plainPassword)) {
throw new \Exception('The password can not be empty.');
Expand All @@ -241,13 +235,7 @@ public function passwordValidator($plainPassword)
return $plainPassword;
}

/**
* This internal method should be private, but it's declared as public to
* maintain PHP 5.3 compatibility when using it in a callback.
*
* @internal
*/
public function emailValidator($email)
private function emailValidator($email)
{
if (empty($email)) {
throw new \Exception('The email can not be empty.');
Expand All @@ -260,13 +248,7 @@ public function emailValidator($email)
return $email;
}

/**
* This internal method should be private, but it's declared as public to
* maintain PHP 5.3 compatibility when using it in a callback.
*
* @internal
*/
public function fullNameValidator($fullName)
private function fullNameValidator($fullName)
{
if (empty($fullName)) {
throw new \Exception('The full name can not be empty.');
Expand Down