Skip to content

Install stty required for tests on ubuntu-latest #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

bocharsky-bw
Copy link
Contributor

In every test job we have skipped tests:

Run vendor/bin/simple-phpunit -v
PHPUnit 9.5.4 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.0.5
Configuration: /home/runner/work/demo/demo/phpunit.xml.dist
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing 
SSSS...........................................                   47 / 47 (100%)

Time: 00:14.918, Memory: 74.50 MB

There were 4 skipped tests:

1) App\Tests\Command\AddUserCommandTest::testCreateUserNonInteractive with data set #0 (false)
`stty` is required to test this command.

/home/runner/work/demo/demo/tests/Command/AddUserCommandTest.php:35

2) App\Tests\Command\AddUserCommandTest::testCreateUserNonInteractive with data set #1 (true)
`stty` is required to test this command.

/home/runner/work/demo/demo/tests/Command/AddUserCommandTest.php:35

3) App\Tests\Command\AddUserCommandTest::testCreateUserInteractive with data set #0 (false)
`stty` is required to test this command.

/home/runner/work/demo/demo/tests/Command/AddUserCommandTest.php:35

4) App\Tests\Command\AddUserCommandTest::testCreateUserInteractive with data set #1 (true)
`stty` is required to test this command.

/home/runner/work/demo/demo/tests/Command/AddUserCommandTest.php:35

OK, but incomplete, skipped, or risky tests!
Tests: 47, Assertions: 92, Skipped: 4.

Remaining indirect deprecation notices (1)

  1x: The "DAMA\DoctrineTestBundle\Doctrine\DBAL\AbstractStaticDriverV2" class implements "Doctrine\DBAL\Driver\ExceptionConverterDriver" that is deprecated.
    1x in PHPUnitExtension::executeBeforeFirstTest from DAMA\DoctrineTestBundle\PHPUnit

It would be good to run those tests at least on Ubuntu I think

@bocharsky-bw bocharsky-bw force-pushed the stty branch 3 times, most recently from 53e201d to 5d8ee31 Compare June 21, 2021 12:36
@bocharsky-bw
Copy link
Contributor Author

Looks like the stty check wasn't perfect and does not work for GitHub actions. I simplified the condition to actually test those commands on GitHub actions for Ubuntu / Mac OS. If anyone will have problems running tests on their Ubuntu / Mac OS - please, feel free to tweak that part and make sure tests are not skipped on GitHub Actions. But so far tests are green with these changes now :)

Failed "Lint / Linters" was fixed in a separate PR, see #1227

@javiereguiluz
Copy link
Member

Thanks a lot Victor. You are right that we can later tweak this as needed ... but for now, it's great to test these commands on GitHub actions again. Thanks!

@javiereguiluz javiereguiluz merged commit 7ed6c4a into symfony:main Jun 21, 2021
@bocharsky-bw bocharsky-bw deleted the stty branch June 21, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants