Use same URL for login form and check #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,8 +25,7 @@ | |||
| class SecurityController extends Controller | |||
| { | |||
| /** | |||
| * @Route("/login", name="security_login_form") | |||
| * @Method("GET") | |||
There was a problem hiding this comment.
This had to be removed, as the router will error when we submit the form. It wasn't very usefull anyways...
|
👍 I like this change a lot! Thanks Wouter. |
|
👍 |
|
It's merged now! Thanks. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 23, 2016
This PR was merged into the master branch. Discussion ---------- Use same URL for login form and check The Security Form login listener will only intercept the request when it's a POST request, otherwise the controller will be executed. Using the same URL makes things a bit easier, removes the need for the weird controller (which is visited, but should not be executed) and makes things similar to other forms. Related doc tickets: * symfony/symfony-docs#6126 * symfony/symfony-docs#6143 Commits ------- b7705cb Use same URL for login form and check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Security Form login listener will only intercept the request when it's a POST request, otherwise the controller will be executed. Using the same URL makes things a bit easier, removes the need for the weird controller (which is visited, but should not be executed) and makes things similar to other forms.
Related doc tickets: