Skip to content

Add PHP CS fixer for this application #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

bocharsky-bw
Copy link
Contributor

Resolve #395.

@javiereguiluz
Copy link
Member

@bocharsky-bw thanks for working on this!

I have two questions:

  1. Is it recommended to add PHP-CS-Fixer as a project dependency or is it better to install it as a global tool in your computer?

  2. Which is the default list of fixers applied when you don't select any config? I've seen some fixers in the official docs that are interesting but I don't know if they are enabled. For example: phpdoc_order, short_array_syntax, ordered_use, etc.

@bocharsky-bw
Copy link
Contributor Author

bocharsky-bw commented Nov 13, 2016

Hey @javiereguiluz

  1. Actually, I don't know, but I did the same way as we had done with PhpUnit. I wonder others opinion about it.

  2. As I see in docs:

By default, all PSR-2 fixers and some additional ones are run.

So I specified Symfony level explicitly and added a few fixers from Contrib level that you had suggested.

@javiereguiluz
Copy link
Member

@bocharsky-bw very nice! Thanks. Let's wait for others opinion about adding PHP-CS-Fixer as a dependency or not.

@javiereguiluz
Copy link
Member

@bocharsky-bw you did a great work here. Thank you! I'm merging it because we can always tweak this config later to add/remove more fixers if needed.

@bocharsky-bw bocharsky-bw deleted the php-cs-fixer branch November 18, 2016 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants