app.json "test" script for Heroku CI #406
Conversation
|
poke :) |
|
Any chance to get this merged before SymfonyCon begins @javiereguiluz? :) |
|
I know nothing about Heroku ... so I cannot review or test this myself. I was waiting to receive any approval/reject comment from anyone. Luckily you are trustworthy, so I guess I'll have to merge this blindly. |
| "postdeploy": "php bin/console doctrine:schema:create && php bin/console doctrine:fixtures:load -n" | ||
| "postdeploy": "php bin/console doctrine:schema:create && php bin/console doctrine:fixtures:load -n", | ||
| "test-setup": "php bin/console doctrine:schema:create && php bin/console doctrine:fixtures:load -n", | ||
| "test": "phpunit" |
There was a problem hiding this comment.
Is there any chance to use ./vendor/bin/phpunit here since we lock PHPUnit's version in the dev dependencies?
There was a problem hiding this comment.
$(composer config bin-dir) is on $PATH on Heroku, so it uses the right one. I can change it though.
This actually begs the related question if it might be a good best practice for this project to, in composer.json, have a test entry in scripts that says phpunit? Then people can run composer test, similar to how they'd do with NPM ;)
|
Has CI already worked on Heroku for users? I triggered an error in unit tests here, but Heroku still successfully build the app without any errors. Should we wait until this feature will be stable and available for all Heroku users? I see you mentioned it's currently in beta. |
|
@dzuelke is there any doc about Heroku CI anywhere ? I haven't found any |
|
It's in private beta, @bocharsky-bw and @stof. I'm also happy to wait with this PR until it's GA, @javiereguiluz :) |
|
This is now in public beta, so merge away, @stof or @bocharsky-bw :) |
|
Thank you @dzuelke. |
This PR was merged into the master branch. Discussion ---------- app.json "test" script for Heroku CI This allows tests to automatically run in the (currently in beta) Heroku CI service. Commits ------- 1e46fd1 app.json "test" script for Heroku CI
This allows tests to automatically run in the (currently in beta) Heroku CI service.