Skip to content

Move SQLite DB to the var/ directory #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bocharsky-bw
Copy link
Contributor

According to the changes in Symfony SE: symfony/symfony-standard#1032

@javiereguiluz
Copy link
Member

👍 It totally makes sense.

@stof
Copy link
Member

stof commented Dec 20, 2016

it should be excluded from the gitignore rules though to be consistent with the previous setup. Currently, var/* is ignored (with some whitelist in it)

@bocharsky-bw
Copy link
Contributor Author

@stof What about to add this to .gitignore:

!/var/data
/var/data/*
!var/data/.gitkeep

@stof
Copy link
Member

stof commented Dec 20, 2016

Well, we don't want to ignore the var/data/blog.sqlite file AFAIK

@bocharsky-bw
Copy link
Contributor Author

But we also don't want to encourage other devs to commit their DB into the repository. We added blog.sqlite to the repository only for our demo purposes.

@stof
Copy link
Member

stof commented Dec 20, 2016

@bocharsky-bw this repo is the demo, not the starting point for new projects (which is what symfony-standard is). So the rules should match the needs of the demo.
A real project should probably not use sqlite for its main storage anyway, as this is incompatible with any deployment involving multiple servers (as they would each have a separate DB) and with any PaaS (as they replace the server when deploying, going back to the point about multiple server, plus they often advocate redundancy so having multiple servers too)

@bocharsky-bw
Copy link
Contributor Author

Thanks @stof, it makes sense. I fixed it in a3bdaf1

@stof
Copy link
Member

stof commented Dec 20, 2016

👍

@javiereguiluz
Copy link
Member

Thanks @bocharsky-bw.

@bocharsky-bw bocharsky-bw deleted the move-db branch December 20, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants