Removed the unused SwiftMailerBundle #420
Conversation
|
There's some Swiftmailer code in |
|
IMO, since it comes out-of-the-box with Symfony SE I'd rather add a simple example of its usage instead of remove it at all. |
|
One of the main problems is that we want the Symfony Demo fully working ... and you can't do that with SwiftMailer. We can't make SwiftMailer work and send emails for our users, because that means that they need to add some config parameters in the application with their Gmail or mail server credentials. |
|
I mean using The Mail Transport, i.e. native PHP mail() function for sending emails, but as I see, it has some issues too, so probably removing Swiftmailer is the best option here 👍 |
|
@bocharsky-bw problem is that the mail transport has been deprecated and it will be removed soon: swiftmailer/swiftmailer@905b0bc |
|
@javiereguiluz, we can disable email sendig in the configuration swiftmailer:
disable_delivery: true |
|
@voronkovich yes ... but actually I'm looking for the opposite. If we want to showcase the SwiftMailer feature ... then the email sending must work and developers must receive some emails somewhere. |
|
@javiereguiluz Ah, then removing Swiftmailer makes even more sense... thanks! |
|
Seeing the Mails in the Web Debug Toolbar is not enough? |
|
@javiereguiluz, developers can view the sent email in the debug toolbar |
|
@frastel @voronkovich you are right! Maybe some "fake sending" is enough to showcase this feature. |
|
Closing in favor of other PRs that will make use of the SwiftMailer bundle. |
…voronkovich, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Notify post author about new comments by sending email See #420 Commits ------- 7dc958c Change prefix for translation messages f918956 Use '_fragment' parameter 1e83a1d Final round of help notes improvements bbc4077 Improved more help notes a596761 Improved some help notes ec601b6 Minor reword in the help note f37e552 Minor tweaks in the translation strings 4125af9 Add note about event listener's method f3b258a Remove default value for sender property b4a97be Use event listener and custom event trigger 7b6ba9a Notify post author about new comments
…voronkovich, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Notify post author about new comments by sending email See symfony/demo#420 Commits ------- 7dc958c Change prefix for translation messages f918956 Use '_fragment' parameter 1e83a1d Final round of help notes improvements bbc4077 Improved more help notes a596761 Improved some help notes ec601b6 Minor reword in the help note f37e552 Minor tweaks in the translation strings 4125af9 Add note about event listener's method f3b258a Remove default value for sender property b4a97be Use event listener and custom event trigger 7b6ba9a Notify post author about new comments
…voronkovich, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Notify post author about new comments by sending email See symfony/demo#420 Commits ------- 7dc958c Change prefix for translation messages f918956 Use '_fragment' parameter 1e83a1d Final round of help notes improvements bbc4077 Improved more help notes a596761 Improved some help notes ec601b6 Minor reword in the help note f37e552 Minor tweaks in the translation strings 4125af9 Add note about event listener's method f3b258a Remove default value for sender property b4a97be Use event listener and custom event trigger 7b6ba9a Notify post author about new comments
…voronkovich, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Notify post author about new comments by sending email See symfony/demo#420 Commits ------- 7dc958c Change prefix for translation messages f918956 Use '_fragment' parameter 1e83a1d Final round of help notes improvements bbc4077 Improved more help notes a596761 Improved some help notes ec601b6 Minor reword in the help note f37e552 Minor tweaks in the translation strings 4125af9 Add note about event listener's method f3b258a Remove default value for sender property b4a97be Use event listener and custom event trigger 7b6ba9a Notify post author about new comments
Related to #417 and created to see if the community agrees or not with this change. Thanks!