Skip to content

Improved the event subscriber that listens to database exceptions #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Improved the event subscriber that listens to database exceptions #452

merged 1 commit into from
Feb 7, 2017

Conversation

javiereguiluz
Copy link
Member

This finishes #431 by doing some renaming and minor tweaks.

// See: http://api.symfony.com/3.2/Symfony/Component/HttpKernel/KernelEvents.html
KernelEvents::EXCEPTION => 'onKernelException',
ConsoleEvents::EXCEPTION => 'handleConsoleException',
// See: http://api.symfony.com/master/Symfony/Component/HttpKernel/KernelEvents.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use current on the API doc or no ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my first try, but ...

api_current

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then fine with using master

@stof
Copy link
Member

stof commented Feb 7, 2017

👍

@javiereguiluz javiereguiluz merged commit 3387540 into symfony:master Feb 7, 2017
javiereguiluz added a commit that referenced this pull request Feb 7, 2017
…eptions (javiereguiluz)

This PR was merged into the master branch.

Discussion
----------

Improved the event subscriber that listens to database exceptions

This finishes #431 by doing some renaming and minor tweaks.

Commits
-------

3387540 Improved the event subscriber that listens to database exceptions
@javiereguiluz javiereguiluz mentioned this pull request Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants