Rename .php_cs to .php_cs.dist as a best practise

[B-Galati]

Hello,

Everything is in the title.

I also removed the shebang because it looked useless, let me know if I am wrong :-)

[bocharsky-bw]

This line helps IDEs with autocompletion since the .php_cs.dist filename doesn't have .php extension

[B-Galati]

I had this issue too with PhpStorm but I was able to force the language syntax by using "Associate with file Type" action. Any thought ?

[bocharsky-bw]

Since this script isn't executable - makes sense to remove this line 👍

[javiereguiluz]

@B-Galati thanks for this contribution! However, I'm not entirely sure this is the right thing to do for this project. The .php_cs file defines the rules for our own code. If we create a .php_cs.dist file is like saying to our users: "hey, .php_cs.dist are our default CS rules ... but you can change them if you want in your own .php_cs file". Well, you can't change those rules. If you change them, we won't merge your PRs.

Do you agree that in this case and for this project, the .php_cs file should always be forced to all users and no customization is possible?

[bocharsky-bw]

@javiereguiluz I agree that we should force the rules we have before merging new PRs. But I'm OK with .php_cs.dist since this way we will allow developers to play with coding standards locally without having dirty repository state. Actually, the same for phpunit.xml.dist. Why don't we force devs with phpunit.xml file? So I think it's a good idea to rename this to .php_cs.dist since it's a good practice. Anyway, I run php-cs-fixer very rare locally before pushing code and always rely on CI. And if the tests are failed, then I need to run it locally to be sure they're fixed before pushing changes the second time.

[B-Galati]

@javiereguiluz I totally agree with @bocharsky-bw. As long as the CI is enforcing mandatory rules, there is no harm to allow for more flexibility to my point of view.

[javiereguiluz]

I don't like this ... but I'm going to merge it because it's coherent with the other .dist files that we use in Symfony. Thanks @B-Galati.

[B-Galati]

@javiereguiluz Thanks !