Skip to content

Reduce the BCrypt cost in tests to run them much faster #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2017
Merged

Reduce the BCrypt cost in tests to run them much faster #737

merged 1 commit into from
Dec 27, 2017

Conversation

javiereguiluz
Copy link
Member

I learned this cool trick from this @taylorotwell tweet: https://twitter.com/taylorotwell/status/943135617466105856

In my local machine, tests went from 15 to 10 seconds!

Copy link
Contributor

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for faster tests

@javiereguiluz javiereguiluz merged commit 54c2ebe into symfony:master Dec 27, 2017
javiereguiluz added a commit that referenced this pull request Dec 27, 2017
…aviereguiluz)

This PR was merged into the master branch.

Discussion
----------

Reduce the BCrypt cost in tests to run them much faster

I learned this cool trick from this @taylorotwell tweet: https://twitter.com/taylorotwell/status/943135617466105856

In my local machine, tests went from 15 to 10 seconds!

Commits
-------

54c2ebe Reduce the BCrypt cost in tests to run them much faster
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jan 2, 2018
This PR was squashed before being merged into the 3.3 branch (closes #8925).

Discussion
----------

Added a tip about tests and BCrypt

Related to symfony/demo#737.

Commits
-------

af8537a Added a tip about tests and BCrypt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants