Switch to Doctrine's Pager #991
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 4, 2019
|
@stof thanks for your review! I've changed some things thanks to your review. |
bocharsky-bw
reviewed
Jun 5, 2019
stof
reviewed
Jun 5, 2019
|
Great change! Straightforward, clear, customizable… Now to all questions like "How to create a paginator?", just need to answer "Look at Symfony Demo" 👍 |
|
It would be better if |
|
I think PhpStorm IDE should figure out those array keys and suggest autocompleting for them... Not sure about autocompleting in Twig templates but it should work in PHP files as far as I know. But agree, paginator object will give us more strict format for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pagerfanta library could be soon be unmaintained: whiteoctober/Pagerfanta#278
Let's switch to Doctrine Pager.