Skip to content

Commit 65f040d

Browse files
Merge branch '4.4' into 5.0
* 4.4: Relax tests to unlock change on master [DI] fix dumping deprecated private aliases [DI] fix typo in Preloader
2 parents e155f1c + 31d8263 commit 65f040d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Dumper/Preloader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ private static function doPreload(string $class, array &$preloaded): void
8585
self::preloadType($p->getType(), $preloaded);
8686
}
8787

88-
self::preloadType($p->getReturnType(), $preloaded);
88+
self::preloadType($m->getReturnType(), $preloaded);
8989
}
9090
} catch (\ReflectionException $e) {
9191
// ignore missing classes

Dumper/YamlDumper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,8 @@ private function addServiceAlias(string $alias, Alias $id): string
163163
{
164164
$deprecated = $id->isDeprecated() ? sprintf(" deprecated: %s\n", $id->getDeprecationMessage('%alias_id%')) : '';
165165

166-
if ($id->isPrivate()) {
167-
return sprintf(" %s: '@%s'\n%s", $alias, $id, $deprecated);
166+
if (!$id->isDeprecated() && $id->isPrivate()) {
167+
return sprintf(" %s: '@%s'\n", $alias, $id);
168168
}
169169

170170
return sprintf(" %s:\n alias: %s\n public: %s\n%s", $alias, $id, $id->isPublic() ? 'true' : 'false', $deprecated);

0 commit comments

Comments
 (0)