Protect removing from FrozenParameterBag #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * {@inheritdoc} | ||
| * | ||
| * @api |
There was a problem hiding this comment.
The @api tag should be removed as it is implied by {@inheritdoc}
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 26, 2015
…ved Parameter… (Tomaz Ahlin) This PR was squashed before being merged into the 2.3 branch (closes #15172). Discussion ---------- [DependencyInjection] fixed FrozenParameterBag and improved Parameter… The ParameterBagInterface was missing some @throws annotations, so the FrozenParameterBag class was a violation of Liskov subtitution principle. Also the ParameterBagInterface was missing the remove method. (Optionally the ParameterBagInterface can be later split into two smaller interfaces, because the FrozenParameterBag shouldn't have the add, remove methods in the first place.) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I have also fixed removing elements from FrozenParameterBag, as introduced by @satahippy symfony/dependency-injection#8 Commits ------- 3ad0794 [DependencyInjection] fixed FrozenParameterBag and improved Parameter…
fabpot
added a commit
that referenced
this pull request
Jul 26, 2015
…ved Parameter… (Tomaz Ahlin) This PR was squashed before being merged into the 2.3 branch (closes #15172). Discussion ---------- [DependencyInjection] fixed FrozenParameterBag and improved Parameter… The ParameterBagInterface was missing some @throws annotations, so the FrozenParameterBag class was a violation of Liskov subtitution principle. Also the ParameterBagInterface was missing the remove method. (Optionally the ParameterBagInterface can be later split into two smaller interfaces, because the FrozenParameterBag shouldn't have the add, remove methods in the first place.) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I have also fixed removing elements from FrozenParameterBag, as introduced by @satahippy #8 Commits ------- 3ad0794 [DependencyInjection] fixed FrozenParameterBag and improved Parameter…
|
This is a read only repository. Pull Request should be send to https://github.com/symfony/symfony. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it behaves like methods clean, set, etc.