Fix extract method to avoid recalculating count() for each iteration.
#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache the value of `count($attributes)` to avoid recalculating it for each iteration of the loop. Since this count will never change during the method execution, this change make the code a bit more efficient.
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Nov 29, 2013
…ach iteration. (fabpot) This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9651). Discussion ---------- Fix `extract` method to avoid recalculating count() for each iteration. This PR was submitted on the symfony/DomCrawler read-only repository and moved automatically to the main Symfony repository (closes symfony/dom-crawler#16). Cache the value of `count($attributes)` to avoid recalculating it for each iteration of the loop. Since this count will never change during the method execution, this change make the code a bit more efficient. Commits ------- 9ababf4 Fix `extract` method to avoid recalculating count() for each iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the value of
count($attributes)to avoid recalculating it for each iteration of the loop.Since this count will never change during the method execution, this change make the code a bit more efficient.