bug #551 Compare paths by their realpath when checking locks (leongersen)

This PR was squashed before being merged into the 1.8-dev branch.

Discussion
----------

Compare paths by their realpath when checking locks

Use `realpath` to compare locked files before removal.

Fixes #513

To test:
```
composer create-project symfony/skeleton example
cd example/vendor/symfony/
rm -rf flex
git clone https://github.com/leongersen/flex --branch issue-513 --single-branch
cd ../../
composer require symfony/test-pack
composer remove symfony/test-pack
```

Commits
-------

9ac4a0a Compare paths by their realpath when checking locks

Author: nicolas-grekas

src/Configurator/CopyFromRecipeConfigurator.php

@@ -46,8 +46,12 @@ function (array $carry, array $package) {
         );
 
         $removableFiles = $recipe->getFiles();
-        foreach ($lockedFiles as $file) {
-            if (isset($removableFiles[$file])) {
+
+        $lockedFiles = array_map('realpath', $lockedFiles);
+
+        // Compare file paths by their real path to abstract OS differences
+        foreach (array_keys($removableFiles) as $file) {
+            if (\in_array(realpath($file), $lockedFiles)) {
                 unset($removableFiles[$file]);
             }
         }

tests/Configurator/CopyFromRecipeConfiguratorTest.php

@@ -104,7 +104,7 @@ public function testUnconfigureKeepsLockedFiles()
         $this->assertFileExists($this->sourceFile);
 
         $lock = new Lock(FLEX_TEST_DIR.'/test.lock');
-        $lock->set('other-recipe', ['files' => [$this->targetFileRelativePath]]);
+        $lock->set('other-recipe', ['files' => ['./'.$this->targetFileRelativePath]]);
 
         $this->createConfigurator()->unconfigure($this->recipe, [$this->targetFileRelativePath], $lock);