Skip to content

Compare paths by their realpath when checking locks #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

leongersen
Copy link
Contributor

@leongersen leongersen commented Aug 10, 2019

Use realpath to compare locked files before removal.

Fixes #513

To test:

composer create-project symfony/skeleton example
cd example/vendor/symfony/
rm -rf flex
git clone https://github.com/leongersen/flex --branch issue-513 --single-branch
cd ../../
composer require symfony/test-pack
composer remove symfony/test-pack

@nicolas-grekas
Copy link
Member

Thank you @leongersen.

@nicolas-grekas nicolas-grekas merged commit 319f785 into symfony:master Jul 24, 2020
tgalopin pushed a commit to tgalopin/flex that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing test-pack deletes config/bootstrap.php
4 participants